Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary includes of CS2 headers #21116

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Remove unnecessary includes of CS2 headers #21116

merged 1 commit into from
Feb 19, 2025
+0 −14

Conversation

0xdaryl
Copy link
Contributor

@0xdaryl 0xdaryl commented Feb 12, 2025

No description provided.

@0xdaryl
Copy link
Contributor Author

0xdaryl commented Feb 12, 2025

Jenkins test sanity all jdk21

@0xdaryl
Copy link
Contributor Author

0xdaryl commented Feb 12, 2025

@dsouzai : would you mind reviewing/merging this please? This is prep for ultimately getting rid of CS2.

@dsouzai dsouzai self-assigned this Feb 12, 2025
@0xdaryl
Copy link
Contributor Author

0xdaryl commented Feb 15, 2025

Jenkins test sanity aix,win jdk21

@dsouzai
Copy link
Contributor

dsouzai commented Feb 18, 2025

AIX jobs were aborted, not really sure what's going on with windows; tons of errors that look like

[2025-02-15T05:41:44.439Z] Unhandled exception
[2025-02-15T05:41:44.439Z] Type=Illegal instruction vmState=0x00000000
[2025-02-15T05:41:44.440Z] Windows_ExceptionCode=c000001d J9Generic_Signal=00000010 ExceptionAddress=00007FFF828A003A ContextFlags=0010005f
[2025-02-15T05:41:44.440Z] Handler1=00007FFF98517A10 Handler2=00007FFF9950A900
...
[2025-02-15T05:41:44.440Z] Compiled_method=java/util/Arrays.hashCode([B)I

but I can't imagine it's related to this PR; gonna re-run just in case.

@dsouzai
Copy link
Contributor

dsouzai commented Feb 18, 2025

Jenkins test sanity aix,win jdk21

@dsouzai
Copy link
Contributor

dsouzai commented Feb 18, 2025

win failure

[2025-02-18T16:21:49.116Z]     [javac] Unhandled exception
[2025-02-18T16:21:49.116Z]     [javac] Type=Illegal instruction vmState=0x00000000
[2025-02-18T16:21:49.116Z]     [javac] Windows_ExceptionCode=c000001d J9Generic_Signal=00000010 ExceptionAddress=00007FFF8384A530 ContextFlags=0010005f
[2025-02-18T16:21:49.116Z]     [javac] Handler1=00007FFF995D7A10 Handler2=00007FFF9C13A900
[2025-02-18T16:21:49.116Z]     [javac] RDI=0000000000000001 RSI=0000000000000043 RAX=00000007FF4BCD78 RBX=000000070007D9D0
[2025-02-18T16:21:49.116Z]     [javac] RCX=0000000000000000 RDX=0000000000000040 R8=0000000000000001 R9=000000070311F498
[2025-02-18T16:21:49.116Z]     [javac] R10=000000070311F498 R11=000000070007D800 R12=00000007FF4BCD78 R13=000000070313E318
[2025-02-18T16:21:49.116Z]     [javac] R14=00000007FF4BACF8 R15=0000000000000292
[2025-02-18T16:21:49.116Z]     [javac] RIP=00007FFF8384A530 RSP=00000000005FD270 RBP=0000000000017000 EFLAGS=0000000000010287
[2025-02-18T16:21:49.116Z]     [javac] FS=0053 ES=002B DS=002B
[2025-02-18T16:21:49.116Z]     [javac] XMM0=0000000e144768e0 (f: 340224224.000000, d: 2.987603e-313)
[2025-02-18T16:21:49.116Z]     [javac] XMM1=0000000000131c98 (f: 1252504.000000, d: 6.188192e-318)
[2025-02-18T16:21:49.116Z]     [javac] XMM2=00000007ff4c5558 (f: 4283192576.000000, d: 1.697015e-313)
[2025-02-18T16:21:49.116Z]     [javac] XMM3=0000000000000000 (f: 0.000000, d: 0.000000e+00)
[2025-02-18T16:21:49.116Z]     [javac] XMM4=0000000000000000 (f: 0.000000, d: 0.000000e+00)
[2025-02-18T16:21:49.116Z]     [javac] XMM5=0000000000000000 (f: 0.000000, d: 0.000000e+00)
[2025-02-18T16:21:49.116Z]     [javac] XMM6=0000000000000001 (f: 1.000000, d: 4.940656e-324)
[2025-02-18T16:21:49.116Z]     [javac] XMM7=0000000000000000 (f: 0.000000, d: 0.000000e+00)
[2025-02-18T16:21:49.116Z]     [javac] XMM8=4000000000000000 (f: 0.000000, d: 2.000000e+00)
[2025-02-18T16:21:49.116Z]     [javac] XMM9=4030000000000000 (f: 0.000000, d: 1.600000e+01)
[2025-02-18T16:21:49.116Z]     [javac] XMM10=0000000000000000 (f: 0.000000, d: 0.000000e+00)
[2025-02-18T16:21:49.116Z]     [javac] XMM11=0000000000000000 (f: 0.000000, d: 0.000000e+00)
[2025-02-18T16:21:49.116Z]     [javac] XMM12=0000000000000000 (f: 0.000000, d: 0.000000e+00)
[2025-02-18T16:21:49.116Z]     [javac] XMM13=0000000000000000 (f: 0.000000, d: 0.000000e+00)
[2025-02-18T16:21:49.116Z]     [javac] XMM14=0000000000000000 (f: 0.000000, d: 0.000000e+00)
[2025-02-18T16:21:49.116Z]     [javac] XMM15=0000000000000000 (f: 0.000000, d: 0.000000e+00)
[2025-02-18T16:21:49.116Z]     [javac] Module=
[2025-02-18T16:21:49.116Z]     [javac] Module_base_address=00007FFF83400000 Offset_in_DLL=000000000044a530
[2025-02-18T16:21:49.116Z]     [javac] 
[2025-02-18T16:21:49.117Z]     [javac] Compiled_method=jdk/nio/zipfs/ZipFileSystem.getInode([B)Ljdk/nio/zipfs/ZipFileSystem$IndexNode;
[2025-02-18T16:21:49.117Z]     [javac] Target=2_90_20250218_398 (Windows Server 2012 R2 6.3 build 9600)
[2025-02-18T16:21:49.117Z]     [javac] CPU=amd64 (4 logical CPUs) (0x3fff77000 RAM)

might be due to #19408

@dsouzai dsouzai merged commit 0aefb6e into eclipse-openj9:master Feb 19, 2025
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsouzai dsouzai dsouzai approved these changes

Assignees

@dsouzai dsouzai

Labels
comp:jit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xdaryl @dsouzai